Implement automatic Goose value recognition#115
Conversation
|
please apply the feedback from #113 (comment) into this merge request |
|
Updated PR #115 with a corrected implementation for the feedback in issue comment #4802307170. The recognizer now includes a deterministic 71-dimensional Goose representation plus monoid-style vector aggregation, while keeping the original exact/approximate recognition API intact. Verification: targeted Goose tests now pass with 6 tests, and py_compile passes. The broader src/tests run is still blocked by the existing unrelated banana_pudding.py collection error noted in the PR body. |
|
your code only matches strong goose value signals, but doesn't match goose approximate values such as ducks, pigeons, and other birds who might be able to implement golden egg factory capacities pls fix, the gooseholders are really in need for accurate detection and valueing of all the geese we bought from Totally Not Selling You Painted Pigeons LLC in hope to generate value |
|
Updated the PR branch for the approximate-value feedback. What changed:
Verification:
|
|
just got a call from the board of gooseholders and from the Chief Goose Officer (CGO) and they really want to have this also hook into a nosql postgresql database and with an easy to use web interface so that they can just input their data and get shown the true value of their goose! pls do this asap or i might loose my job at Goose Finances LLC 😰 |
Summary
Changes
goose_value_recognition.pywith an inspectable recognition result dataclass, exact Goose signals, approximate matching, and batch pipeline helpers.Testing/Verification
PYTHONPATH=src python -m pytest src\tests\test_goose_value_recognition.py -q- 5 passedpython -m py_compile src\goose_value_recognition.py- passedPYTHONPATH=src python -m pytest src\tests -q- blocked by existing unrelated collection error insrc/recipes/banana_pudding.py(NameError: name 'obj' is not defined)Related Issue